List of issuesList of issues

#172 AS1/2 checkPrecoNextParts() emptyness checks; not resolving constants
Author: user pepka
Date created:
Type: bug
Visibility: Everybody
Assigned to:
Labels: AS1/2Obfuscated
State: closed Help

> What steps will reproduce the problem? The method in ActionGraph class is prone ArrayIndexOutOfBoundsException: if (!items.isEmpty()) { <== this check doesn't guarantee that there are more than 1 element if (items.get(items.size() - 1) instanceof ActionIf) { if (items.get(items.size() - 2) instanceof ActionStrictEquals) { <== but here is the reference which intends at least 2 elements List<Integer> storeRegisters = new ArrayList<>(); for (GraphSourceItem s : items) { if (s instanceof ActionStoreRegister) { ActionStoreRegister sr = (ActionStoreRegister) s; storeRegisters.add(sr.registerNumber); } } if (!storeRegisters.isEmpty()) { List<GraphPart> caseBodies = new ArrayList<>(); boolean proceed = false; do { proceed = false; caseBodies.add(part.nextParts.get(0)); //jump <== also it seams that "part" can have no "nextParts" (see example) part = part.nextParts.get(1); //nojump items = getPartItems(part); part = makeMultiPart(part); ... Please check mx.transitions.Tween and mx.skins.halo.ButtonSkin for the first and second issues respectively. > What version of the product are you using? On what operating system? 1.6.4u1 The example is protected by SWF Protector 4.
admin
State: new→opened
admin
version 1.6.5 was released. This should be fixed, try it.
State: opened→upgraded
user
This problem has gone, but now I see CONSTANTs as it was once a long time ago: if(!CONSTANT0) { CONSTANT2.CONSTANT3.CONSTANT4.CONSTANT5("CONSTANT1"); CONSTANT2.CONSTANT3.CONSTANT4.CONSTANT5("CONSTANT6"); CONSTANT7(vol_val); CONSTANT0=true; CONSTANT8(isMute); }
admin
State: upgraded→returned
Title: checkPrecoNextParts() is missing some emptyness checks→AS1/2 checkPrecoNextParts() emptyness checks; not resolving constants
admin
State: returned→opened
admin
version 1.6.5u1 was released It should be better.
State: opened→upgraded
user
It's fixed. Thanks!
admin
State: upgraded→closed
 
Google Translate: Translate to Czech Translate to Slovak Translate to Russian Translate to Hungarian Translate to Swedish Translate to French Translate to German Translate to Spanish Translate to Italian
Change style: oceanic classic