#654 backslash-escaped file names on command line cause error in Linux

If you are looking for the decompiler itself, visit https://github.com/jindrapetrik/jpexs-decompiler

NEW 03/18/2023: We have got a new blog where we post some interesting SWF internals info.

List of issues

Author:

loki

Date created: 08/26/2014, 1:07:50 pm

Type: bug

Visibility: Everybody

Assigned to: developer

honfika

Labels: Linux

State: closed Help

Normally "\ " is a valid way to use a space on the command line (it autocompleted that way.) > What steps will reproduce the problem? $ ~/Downloads/ffdec_3.0.0_fd9e1de/ffdec.sh -replaceBinaryData ~/wordgamerelease.swf /opt/Word\ Realms/share/wordgamerelease.swf 7 7-modified.bin Exception in thread "main" java.lang.NumberFormatException: For input string: "Realms/share/wordgamerelease.swf" at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65) at java.lang.Integer.parseInt(Integer.java:492) at java.lang.Integer.parseInt(Integer.java:527) at com.jpexs.decompiler.flash.console.CommandLineArgumentParser.parseReplaceBinaryData(Comman dLineArgumentParser.java:1261) at com.jpexs.decompiler.flash.console.CommandLineArgumentParser.parseArguments(CommandLineArg umentParser.java:349) at com.jpexs.decompiler.flash.gui.Main.main(Main.java:904) > What is the expected output? What do you see instead? Not sure, first time trying the replace feature, but see output above. > What version of the product are you using? On what operating system? As above, on Linux Mint 16. > Please provide any additional information below. Attach the file you have problem with if neccessary. If you do not want to publish files YOU CAN CHANGE VISIBILITY TO PRIVATE If I change it to being surrounded by quotes but without the backslash, I get the exact same error. Quotes and backslash, same thing. So I guess there's no way to pass a path containing a space currently?

honfika

08/26/2014, 3:38:47 pm

Please execute the followingcommand with the latest nightly build: ffdec.sh -debug -replaceBinaryData ~/wordgamerelease.swf /opt/Word\ Realms/share/wordgamerelease.swf 7 7-modified.bin This command will print the original arguments (args from main(String[] args) method) If it splits your fileName-filePath, then the problem is not in our sw. Otherwise we will fix it. Please copy the result here. Thanks.

Assigned: → developer

honfika

loki

08/27/2014, 12:48:46 pm

$ ~/Downloads/ffdec_3.0.0_fd9e1de/ffdec.sh -debug -replaceBinaryData ~/wordgamerelease.swf /opt/Word\ Realms/share/wordgamerelease.swf 7 7-spatulacity.bin Exception in thread "main" java.lang.NumberFormatException: For input string: "Realms/share/wordgamerelease.swf" at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65) at java.lang.Integer.parseInt(Integer.java:492) at java.lang.Integer.parseInt(Integer.java:527) at com.jpexs.decompiler.flash.console.CommandLineArgumentParser.parseReplaceBinaryData(Comman dLineArgumentParser.java:1261) at com.jpexs.decompiler.flash.console.CommandLineArgumentParser.parseArguments(CommandLineArg umentParser.java:349) at com.jpexs.decompiler.flash.gui.Main.main(Main.java:904)

loki

08/27/2014, 12:54:44 pm

Sorry, wrong nightly! Just a sec

loki

08/27/2014, 12:56:30 pm

There we go (identical output with quotes instead of '\' ): $ ~/Downloads/ffdec_3.0.0_0a1e132/ffdec.sh -debug -replaceBinaryData ~/wordgamerelease.swf /opt/Word\ Realms/share/wordgamerelease.swf 7 7-spatulacity.bin 0.:-debug 1.:-replaceBinaryData 2.:/home/kev/wordgamerelease.swf 3.:/opt/Word 4.:Realms/share/wordgamerelease.swf 5.:7 6.:7-spatulacity.bin Exception in thread "main" java.lang.NumberFormatException: For input string: "Realms/share/wordgamerelease.swf" at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65) at java.lang.Integer.parseInt(Integer.java:492) at java.lang.Integer.parseInt(Integer.java:527) at com.jpexs.decompiler.flash.console.CommandLineArgumentParser.parseReplaceBinaryData(Comman dLineArgumentParser.java:1267) at com.jpexs.decompiler.flash.console.CommandLineArgumentParser.parseArguments(CommandLineArg umentParser.java:355) at com.jpexs.decompiler.flash.gui.Main.main(Main.java:904)

JPEXS

08/27/2014, 1:35:01 pm

Please try java -jar ... instead of ffdec.sh ... with the backslash and with quotes too

JPEXS

08/27/2014, 1:35:43 pm

sorry, I mean: java -jar ffdec.jar ...

loki

08/27/2014, 2:18:53 pm

That way works: 0.:-debug 1.:-replaceBinaryData 2.:/home/kev/wordgamerelease.swf 3.:/opt/Word Realms/share/wordgamerelease.swf 4.:7 5.:7-spatulacity.bin

loki

08/27/2014, 2:19:49 pm

(with quotes produces the same output as with backslash)

honfika

08/27/2014, 2:27:26 pm

Then the problem seems to be in ffdec.sh Does anyone know how to fix it?

loki

08/27/2014, 2:38:07 pm

Oh, I think I do--just put quotes around the $@ occurences: # Check default java if [ -x "`which java`" ]; then JAVA_VERSION_OUTPUT=`java -version 2>&1` check_java_version && exec java -Djava.net.preferIPv4Stack=true -Xmx$MEMORY -jar $JAR_FILE "$@" fi # Test other possible Java locations for JRE_PATH in $LOOKUP_JRE_DIRS; do if [ -x "$JRE_PATH/bin/java" ]; then JAVA_VERSION_OUTPUT=`"$JRE_PATH/bin/java" -version 2>&1` check_java_version && { export JRE_PATH exec $JRE_PATH/bin/java -Djava.net.preferIPv4Stack=true -Xmx$MEMORY -jar $JAR_FILE "$@" ...that seems to let it work, although every argument then seems to need an absolute path for some reason.

loki

08/29/2014, 12:54:24 pm

Sorry, I hadn't thought to look there...had assumed it was in Java somewhere...thanks!

loki

09/03/2014, 4:51:03 pm

Actually, this might be a bit more quote/script-friendly: # Handle symlinks PROGRAM="$0" while [ -L "$PROGRAM" ]; do PROGRAM=`readlink -f "$PROGRAM"` done cd "`dirname \"$PROGRAM\"`" PARAMS="" for PARAM in "$@" do PARAMS="${PARAMS} \"${PARAM}\"" done # Check default java if [ -x "`which java`" ]; then JAVA_VERSION_OUTPUT=`java -version 2>&1` check_java_version && bash -c "exec java -Djava.net.preferIPv4Stack=true -Xmx$MEMORY -jar $JAR_FILE ${PARAMS}" fi # Test other possible Java locations for JRE_PATH in $LOOKUP_JRE_DIRS; do if [ -x "$JRE_PATH/bin/java" ]; then JAVA_VERSION_OUTPUT=`"$JRE_PATH/bin/java" -version 2>&1` check_java_version && { export JRE_PATH bash -c "exec $JRE_PATH/bin/java -Djava.net.preferIPv4Stack=true -Xmx$MEMORY -jar $JAR_FILE ${PARAMS}" } fi done

loki

09/03/2014, 4:53:19 pm

Actually, maybe that's no good, it then fails the check after that block.

honfika

09/03/2014, 9:01:52 pm

Then how should we fix this? Sorry, I don't know this script.

loki

09/03/2014, 10:02:18 pm

Ah, just take out the bash -c stuff, and it seems to work well: PARAMS="" for PARAM in "$@" do PARAMS="${PARAMS} \"${PARAM}\"" done # Check default java if [ -x "`which java`" ]; then JAVA_VERSION_OUTPUT=`java -version 2>&1` check_java_version && exec java -Djava.net.preferIPv4Stack=true -Xmx$MEMORY -jar $JAR_FILE ${PARAMS} fi # Test other possible Java locations for JRE_PATH in $LOOKUP_JRE_DIRS; do if [ -x "$JRE_PATH/bin/java" ]; then JAVA_VERSION_OUTPUT=`"$JRE_PATH/bin/java" -version 2>&1` check_java_version && { export JRE_PATH exec $JRE_PATH/bin/java -Djava.net.preferIPv4Stack=true -Xmx$MEMORY -jar $JAR_FILE ${PARAMS} } fi done

honfika

09/03/2014, 10:24:32 pm

i've created a nightly build with your modified script. please try it thanks for the fix

State: new→upgraded

loki

09/03/2014, 10:59:48 pm

Actually, sorry, for some reason this still doesn't work. It worked from my script, but not from the straight command line. It should actually be the straight "$@" way I first suggested; when I then fixed my script properly, my script and ffdec from the command-line worked fine.

honfika

09/03/2014, 11:00:34 pm

Please could you attach the working sh file?

loki

09/03/2014, 11:43:04 pm

There, sorry for my confusion.

ffdec.sh (2 KiB)

honfika

09/04/2014, 11:33:49 pm

Thanks, added. Please try the latest nightly build.

loki

09/05/2014, 2:32:00 pm

Works great! Glad to help, thanks for your patience.

honfika

09/05/2014, 2:33:39 pm

State: upgraded→closed